Add the ability to export apps installed in the users home #61
+152
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The only interesting part is within the |
Owner
|
Thank you! I will merge these changes for the next version |
Author
|
Just ping me, if/as soon as I should resolve the conflicts. |
…the distrobox differs
Owner
|
I've rebased to discard the formatting changes, so that I can review everything more easily. |
ranfdev
reviewed
Nov 20, 2025
|
|
||
| fn into_map(self) -> BTreeMap<PathBuf, String> { | ||
| let mut desktop_files = self.system; | ||
| if env::home_dir() != Some(self.home_dir) { |
Owner
There was a problem hiding this comment.
I think when DistroShelf is running as a flatpak, env::home_dir is different than the $HOME of the host?
By running
flatpak enter com.ranfdev.DistroShelf /usr/bin/bash
bash-5.3$ echo $HOME
i get an empty output, so this check doesn't seem to work when running DistroShelf as flatpak
Owner
There was a problem hiding this comment.
I think we should retrieve the $HOME value using flatpak-spawn to echo that env var from the host side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to export/run apps installed in the users home directory (
~/.local/share/applications) if the home within the distrobox differs from the hosts home directory.I did not update the tests as currently they only check if the dummy values are as expected, thus they are not testing any "production" code (as Morty would say: this sounds like asserting true with extra steps ^^). I would look more deeply into the tests if help would be appreciated, but that would be another PR.