Skip to content

Add a normalizer option for Groonga::Normalizer #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
komainu8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a normalizer option for Groonga::Normalizer #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ext/groonga/rb-grn-normalizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ VALUE rb_cGrnNormalizer;
* @param [String] string The original string
*
* @param [::Hash] options The optional parameters.
* @option options :normalizer
* We can specify using normalizer.
* @option options :remove_blank (true)
* If it's `true`, all blank characters are removed.
* @option options :remove_tokenized_delimiter (false)
Expand All @@ -53,6 +55,7 @@ rb_grn_normalizer_s_normalize (int argc, VALUE *argv, VALUE klass)
VALUE rb_context = Qnil;
VALUE rb_string;
VALUE rb_options;
VALUE rb_normalizer_p;
VALUE rb_remove_blank_p;
VALUE rb_remove_tokenized_delimiter_p;
VALUE rb_encoded_string;
Expand All @@ -66,6 +69,7 @@ rb_grn_normalizer_s_normalize (int argc, VALUE *argv, VALUE klass)

rb_scan_args(argc, argv, "11", &rb_string, &rb_options);
rb_grn_scan_options(rb_options,
"normalizer", &rb_normalizer_p,
"remove_blank", &rb_remove_blank_p,
"remove_tokenized_delimiter_p",
&rb_remove_tokenized_delimiter_p,
Expand All @@ -77,6 +81,9 @@ rb_grn_normalizer_s_normalize (int argc, VALUE *argv, VALUE klass)
return rb_grn_context_rb_string_new(context, "", 0);
}

if (!NIL_P(rb_normalizer_p)) {
normalizer = RVAL2GRNOBJECT(rb_normalizer_p, &context);
}
if (NIL_P(rb_remove_blank_p)) {
rb_remove_blank_p = Qtrue;
}
Expand Down
6 changes: 6 additions & 0 deletions test/test-normalizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ def test_space
assert_equal("abcdefgh", Groonga::Normalizer.normalize("AbC Def　gh"))
end

def test_normalizer
assert_equal("©",
Groonga::Normalizer.normalize("©",
:normalizer => "NormalizerNFKC100"))
end

def test_remove_blank
assert_equal("abcdefgh",
Groonga::Normalizer.normalize("AbC Def　gh",
Expand Down