Skip to content

Fix npm trusted publishing and remove redundant test step #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranyitz merged 2 commits into from
Jan 26, 2026
Merged

Fix npm trusted publishing and remove redundant test step #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e43f0
no need to run tests before publish since we require PRs
ranyitz Jan 26, 2026
a1ecdf1
Upgrade to Node 24 for npm trusted publishing OIDC support
ranyitz Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
registry-url: https://registry.npmjs.org
cache: pnpm

- run: pnpm install --frozen-lockfile
- run: pnpm test
- run: npm publish --provenance --access public
Comment on lines 28 to 29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Build artifacts before npm publish

In the tag publish job, pnpm test was the only step that ran pnpm build, and the repo doesn’t check in dist. With the test step removed, the workflow now goes straight from pnpm install to npm publish, so the package is published without compiled dist artifacts even though package.json’s main/bin and files depend on dist. This will produce a broken package on npm for tag pushes; add an explicit build step (or restore a step that runs pnpm build) before publishing.

Useful? React with 👍 / 👎.