Cms refactor #19757
Draft
Cms refactor #19757
+996
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added proper credits for the original research.
bwatters-r7
reviewed
Jan 10, 2025
| @@ -18,7 +24,7 @@ def validate | |||
| validate_session | |||
| elsif rhost | |||
| validate_rhost | |||
| else | |||
| elsif session_or_rhost_required? | |||
There was a problem hiding this comment.
minor; maybe toss in an else at the end if something goes sideways to help debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring work to consolidate CMS (Cryptographic Message Syntax) data structures into the one place. I've tried to place them into three locations:
I kept this separate from #19712 so that we didn't need to test PKINIT as part of the SCCM PR (seemed like a separate concern). Should rebase on that once it's done.
Verification