Shodan facets #20027
Merged
Shodan facets #20027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this is done following suggestions. |
|
Hey! I think something wrong went with pushing your commits as they are now quite a lot of files you're trying to commit. Would you mind reducing it to necessary files? I assume you were trying to rebase on latest |
|
I did reset to previous commit. Let's say the user will know how to use facets, I did not provide any relevant information when modifying the info section anyways. |
|
@msutovsky-r7, I have updated the info section with links from shodan website. |
msutovsky-r7
approved these changes
May 1, 2025
msutovsky-r7
added
rn-enhancement
Release NotesThis adds support for Shodan facets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this pull request implements facets into the shodan_search module.
It's mostly copied code from zoomeye (which was initially copied from this one).
I tested it and it's working as intended, you can save the facets result to the database if requested.
Regards.