-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Update exploit docs to use modern h3 for options instead of original spec (bold) #20625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @h00die 👍
There's an inconsistency that was pre-existing with the indentation of the paragraph following the the triple header. I assume you scripted this, would it be possible to update the script to eliminate that indentation?
It looks like most paragraphs describing the datastore options have been indented with the standard double space, however if there's a quadruple space intent anywhere that will now be interpreted as a code block after the triple intent update, which will be undesirable.
Scripted yes, but then I look everything over to make sure it didn't add anything not needed, and make sure other things look right. I'll take out the indents, should be easy! |
Thanks so much! If you could apply the same changes to 20627 as well, that would be awesome! 🙏 |
|
Check slack, I asked a longer question for clarification |
e7043bd to
f47018f
Compare
|
Wasn't but 2 or 3 in there, but believe I got them! |
|
@jheysel-r7 anything else left? |
A long while ago an r7 employee (forgot who, sorry, but she was awesome in helping spec out the original markdown doc format stuff!) decided we should use h3 (###) instead of bold (**) for Options. There were a lot of old docs, so this is an initial attempt to convert them all in exploit.
Also adds the docs for plist persistence that I forgot to include in the PR: #20527