NtlmRelay2Self module fix check for self delegation via rbcd module#21647
Open
jheysel-r7 wants to merge 4 commits into
Open
NtlmRelay2Self module fix check for self delegation via rbcd module#21647jheysel-r7 wants to merge 4 commits into
jheysel-r7 wants to merge 4 commits into
Conversation
|
Thanks for your pull request! As part of our landing process, we manually verify that all modules work as expected. We've added the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a call to the rbcd module to update the
msDS-AllowedToActOnBehalfOfOtherIdentityattribute of the machine account we're targeting in the ntlm_relay_2_self module to allow for self delegation.Shadow Credentials allows the operator to get a TGT via PKINIT. However unlike traditional constrained delegation, a computer account cannot inherently use S4U2Proxy to delegate to itself unless a Resource-Based Constrained Delegation relationship is explicitly defined.
This is a requirement in order to request a TGS impersonating the administrator as the machine account. If this attribute is not set operators will encounter a KDC_ERR_BADOPTION (13) error.
Why wasn't this an issue before?
Originally the ntlm_relay_2_self module was calling the rbcd module, updating the attribute, and then removing the added entry on clean up. Towards the end of the module review I though this might be unnecessary and deleted the call to the rbcd module. It appears as thought the REMOVE action in the rbcd module is broken, so the
msDS-AllowedToActOnBehalfOfOtherIdentitystayed in my environment and continued to allow the module to work.Breaking Changes
None
Reviewer Notes
Please see the comment I left regarding the shadow creds fix.
Testing Evidence
Before
(This output includes the shadow credentials fix)
After