Ensure argv[0] is not NULL#281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug discovered during the testing of rapid7/metasploit-framework#19799
Specifically, with the introduction of the
in_memory_loader, used to convert the ELF file to a shellcode (mainly to be able to prepend code on it) we deliver an elf file that execute the original mettle stageless payload by creating a file descriptor withmemfd_createand executing it withexecve/execveat. In this scenario, some systems (eg. Ubuntu 16.04 x86) receive an NULL inside the argv[0] making the payload segfault. This PR fixes this issue.