Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] v24.12.00 #805

Merged
merged 11 commits into from
Dec 11, 2024
Merged

[RELEASE] v24.12.00 #805

merged 11 commits into from
Dec 11, 2024

Conversation

raydouglass
Copy link
Member

Fix incorrect squash merge in #799

raydouglass and others added 11 commits September 19, 2024 12:07
Forward-merge branch-24.10 into branch-24.12
Forward-merge branch-24.10 into branch-24.12
Forward-merge branch-24.10 into branch-24.12
Removes the deprecated "look-for" functions and some deprecated argument names ("seed", "random_state" were deprecated in favor of "rng").

Authors:
  - Gregory Lee (https://github.com/grlee77)

Approvers:
  - https://github.com/jakirkham

URL: #786
Forward-merge branch-24.10 into branch-24.12
Contributes to rapidsai/build-planning#106

Proposes specifying the RAPIDS version in `conda install` calls that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)

URL: #791
…792)

Contributes to rapidsai/build-planning#108
Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

* removes the use of build isolation in wheel builds
* printing `sccache` stats to CI logs
* reducing `pip`'s verbosity in wheel building scripts
* using the RAPIDS conventions `py_build_{project}` and `py_rapids_build_{project}` in `dependencies.yaml`
* updating to the latest `rapids-dependency-file-generator` (v1.16.0)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #792
Contributes to rapidsai/build-planning#110

Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI.

* checks on wheel size (compressed),
  - *to be sure they're under PyPI limits*
  - *and to prompt discussion on PRs that significantly increase wheel sizes*
* checks on README formatting
  - *to ensure they'll render properly as the PyPI project homepages*
  - *e.g. like how https://github.com/scikit-learn/scikit-learn/blob/main/README.rst becomes https://pypi.org/project/scikit-learn/*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #797
Nightly conda builds for 24.12 and 25.02 are currently failing because
of file-clobbering issues with `xorg-*` packages. It looks like this is
because those packages on conda-forge are in the middle of a migration.

That clobbering should generally be safe, and anyway is out of our
control, so this PR proposes temporarily allowing it in CI.

See #800 for details.

## Notes for Reviewers

This is intentionally targeting `branch-24.12`, to get nightly builds
working there. A few more are still needed to complete the 24.12
release.
@raydouglass raydouglass requested review from a team as code owners December 11, 2024 18:32
@raydouglass raydouglass requested a review from AyodeAwe December 11, 2024 18:32
@raydouglass raydouglass merged commit ba96cbc into main Dec 11, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants