-
Notifications
You must be signed in to change notification settings - Fork 972
Update ArrowStringView compare benchmark for gather #19935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidwendt
wants to merge
8
commits into
rapidsai:branch-25.12
Choose a base branch
from
davidwendt:umbra-gather
base: branch-25.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
The benchmark results show the ArrowStringView to be much faster for smaller strings but slower for longer strings
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although a simple
thrust::gather
should be enough for gathering/filtering an ArrowStringView/ArrowBinaryView array, in reality it is impractical to share a data buffer between two columns in libcudf. This PR illustrates how acudf::gather
would actually function if ArrowStringView were supported by libcudf. Sharing data in column_views is expected but a libcudf gather (all other libcudf APIs) would return a new column with newly owned (non-shared) data. At best, the data-buffer could be simply copied but it seems impractical in general to not compact the buffer and remove any unused data characters from it. Also, the compaction could help coalesce accessing adjacent row data in down stream calls.Checklist