-
Notifications
You must be signed in to change notification settings - Fork 980
Run cudf-polars conda unit tests with more than 1 process #19980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 24 commits into
rapidsai:branch-25.12
from
mroeschke:ci/cudf_polars/xdist_conda
Sep 26, 2025
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
25aca25
Run cudf-polars conda unit test with more than 1 process
mroeschke 816a133
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke 534883e
Use a dask_cluster session fixture instead of session_start/end confi…
mroeschke f09d147
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke a1458cf
Use less processes for OOMs
mroeschke fa9a77f
Move autouse fixture to experimental conftest.py, allocate less data …
mroeschke ba0179b
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke bb33390
Allocate less memory in test_dask_serialization_roundtrip
mroeschke 6df7cf9
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke 5e37c93
Undo test changes to test_dask_serialize
mroeschke bdc912a
Try only 2 processes?
mroeschke f3372ad
Try function scoping to cleanup after tests
mroeschke ad26cd3
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke e5c7b38
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke 399a730
Merge remote-tracking branch 'upstream/branch-25.10' into ci/cudf_pol…
mroeschke 017bf31
Disable some jobs to isolate polars conda jobs
mroeschke 187c946
Comment out also on pr builder
mroeschke 59d144d
try hardcoding free memory for OOMs
mroeschke 29b3b41
Add fixture to cleare MR cache
TomAugspurger 4c51a08
Undo limiting free_memory initial pool size, try 8 processes
mroeschke 840d206
Revert "Comment out also on pr builder"
mroeschke 2e99088
Revert "Disable some jobs to isolate polars conda jobs"
mroeschke 5d8c909
Merge remote-tracking branch 'upstream/branch-25.12' into ci/cudf_pol…
mroeschke 814a8ac
Try using 6 processes
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| from __future__ import annotations | ||
|
|
||
| import os | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def dask_cluster(pytestconfig, worker_id): | ||
| if ( | ||
| pytestconfig.getoption("--scheduler") == "distributed" | ||
| and pytestconfig.getoption("--executor") == "streaming" | ||
| ): | ||
| worker_count = int(os.environ.get("PYTEST_XDIST_WORKER_COUNT", "0")) | ||
| from dask import config | ||
| from dask_cuda import LocalCUDACluster | ||
|
|
||
| # Avoid "Sending large graph of size ..." warnings | ||
| # (We expect these for tests using literal/random arrays) | ||
| config.set({"distributed.admin.large-graph-warning-threshold": "20MB"}) | ||
| if worker_count > 0: | ||
| # Avoid port conflicts with multiple test runners | ||
| worker_index = int(worker_id.removeprefix("gw")) | ||
| scheduler_port = 8800 + worker_index | ||
| dashboard_address = 8900 + worker_index | ||
| else: | ||
| scheduler_port = None | ||
| dashboard_address = None | ||
|
|
||
| n_workers = int(os.environ.get("CUDF_POLARS_NUM_WORKERS", "1")) | ||
|
|
||
| with ( | ||
| LocalCUDACluster( | ||
| n_workers=n_workers, | ||
| scheduler_port=scheduler_port, | ||
| dashboard_address=dashboard_address, | ||
| ) as cluster, | ||
| cluster.get_client(), | ||
| ): | ||
| yield | ||
| else: | ||
| yield | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this fixture in the experimental directory since currently these are the only tests (with the CI script) that purposefully test with the distributed executor. Is that OK @TomAugspurger given your thoughts on reorganizing the cudf_polars test suite in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that sounds good to me.