Skip to content

Conversation

rjzamora
Copy link
Member

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora self-assigned this Sep 18, 2025
@rjzamora rjzamora added feature request New feature or request 2 - In Progress Currently a work in progress non-breaking Non-breaking change cudf.polars labels Sep 18, 2025
Copy link

copy-pr-bot bot commented Sep 18, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Sep 18, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Sep 18, 2025

@staticmethod
def join_partition(
left_input: int | DataFrame,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types need to be updated to match https://github.com/rapidsai/rapidsmpf/pull/517/files#diff-f053a4fe09712b51b39f32074476d744af1a34774cae7b50a89a49c5b2d7b551R291 I think (cudf.DataFrame | Callable[[int], cudf.DataFrame])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - This needs to be Callable[[int], DataFrame] now.
While prototyping the bcast join, I realized the backend-specific code is much simpler if we are always fetching the partition chunks with a callable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress cudf.polars cudf-polars Issues specific to cudf-polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants