-
Notifications
You must be signed in to change notification settings - Fork 971
[WIP] Leverage fused RapidsMPF Join operation #20018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.10
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
||
@staticmethod | ||
def join_partition( | ||
left_input: int | DataFrame, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types need to be updated to match https://github.com/rapidsai/rapidsmpf/pull/517/files#diff-f053a4fe09712b51b39f32074476d744af1a34774cae7b50a89a49c5b2d7b551R291 I think (cudf.DataFrame | Callable[[int], cudf.DataFrame]
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - This needs to be Callable[[int], DataFrame]
now.
While prototyping the bcast join, I realized the backend-specific code is much simpler if we are always fetching the partition chunks with a callable.
Description
Checklist