Do not check parquet directory for consistency #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Maybe there is a better way to actually do some form of check? The problem is that if we have multiple nodes/utility workers then one of them may lag behind when the director already contains files. However, blocking on this also seems not better. Is there a better way that would allow checking then just an option to disable this check? Signed-off-by: Sebastian Berg <[email protected]>
seberg
force-pushed
the
parquet-no-check
branch
from
89c2bba to
46cb3fb
Compare
Contributor
Author
|
(This is very likely just wrong, but running into the error and need to figure out why, and seeing the code change here may help.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there is a better way to actually do some form of check? The problem is that if we have multiple nodes/utility workers then one of them may lag behind when the director already contains files.
However, blocking on this also seems not better. Is there a better way that would allow checking then just an option to disable this check?
Not sure if we'll have a better idea, otherwise this should fix your problem @reazulhoque (although, may want to check