FIXUP: "fbdev: Allow client to request a particular /dev/fbdevN node" #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
reviewed
Jun 11, 2025
| @@ -460,7 +460,6 @@ static int do_register_framebuffer(struct fb_info *fb_info) | |||
| if (err < 0) | |||
| return err; | |||
|
|
|||
| fb_info->node = i; | |||
| refcount_set(&fb_info->count, 1); | |||
There was a problem hiding this comment.
Doesn't this deletion mean no one is ever setting fb_info->node?
There was a problem hiding this comment.
If the caller has set custom_fb_num then it is also expected to have set fb_info->node to the desired node number.
We search if:
if (!fb_info->custom_fb_num || fb_info->node >= FB_MAX || registered_fb[fb_info->node]) {
ie caller hasn't requested to use the desired number, it's too high, or already registered.
dfc8f67 is the one user of this, and sets both info->node and info->custom_fb_num.
Fixes up forward port to 6.16 Squash in (currently) ee76d85. Signed-off-by: Dave Stevenson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up forward port to 6.16
Squash in (currently) ee76d85.