Skip to content

dts: cm5/pi5: Disable EEE on rp1 #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

nbuchwitz
Copy link
Contributor

Potential fix for #6855

@nbuchwitz nbuchwitz marked this pull request as ready for review June 15, 2025 09:06
@nbuchwitz
Copy link
Contributor Author

Before patch (from partner device):

EEE settings for enx00e04c310eb3:                                                             
        EEE status: enabled - active                                                          
        Tx LPI: disabled                                                                      
        Supported EEE link modes:  100baseT/Full                                              
                                   1000baseT/Full                                             
        Advertised EEE link modes:  100baseT/Full                                             
                                    1000baseT/Full                                            
        Link partner advertised EEE link modes:  100baseT/Full                                
                                                 1000baseT/Full   

After patch (from partner device):

EE settings for enx00e04c310eb3:
        EEE status: enabled - inactive
        Tx LPI: disabled
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  Not reported

The cadence mac on rp1 doesn't support EEE, but unfortunately the phy
advertises otherwise. This leads to high package loss or even unusable
network interfaces in EEE capable setups.

Fix this and mark EEE as broken on phy.

Signed-off-by: Nicolai Buchwitz <[email protected]>
@nbuchwitz nbuchwitz force-pushed the devel/disable-broken-eee branch from c069503 to 9ac6cb2 Compare June 17, 2025 15:39
@pelwell pelwell merged commit 85b196f into raspberrypi:rpi-6.12.y Jun 17, 2025
@pelwell
Copy link
Contributor

pelwell commented Jun 17, 2025

Thanks!

@nbuchwitz nbuchwitz deleted the devel/disable-broken-eee branch June 18, 2025 09:10
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jun 18, 2025
See: raspberrypi/linux#6891

kernel: Fix dwc2 thinkos
See: raspberrypi/linux#6906

kernel: dts: cm5/pi5: Disable EEE on rp1
See: raspberrypi/linux#6900

kernel: GPIO Acquire/Release Semantics for 'AI Camera'
See: raspberrypi/linux#6884

kernel: configs: arm64: Enable the UDMABUF driver
See: raspberrypi/linux#6903

kernel: drm/probe-helper: Ensure cmdline mode matches interlace mode
See: raspberrypi/linux#6902

kernel: media: i2c: Tweak default PDAF gain table in imx708 driver
See: raspberrypi/linux#6901

kernel: drivers: media: imx500: Add device id readback control
See: raspberrypi/linux#6897

kernel: overlays: i2c-rtc: Add M41T80 support
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Jun 18, 2025
See: raspberrypi/linux#6891

kernel: Fix dwc2 thinkos
See: raspberrypi/linux#6906

kernel: dts: cm5/pi5: Disable EEE on rp1
See: raspberrypi/linux#6900

kernel: GPIO Acquire/Release Semantics for 'AI Camera'
See: raspberrypi/linux#6884

kernel: configs: arm64: Enable the UDMABUF driver
See: raspberrypi/linux#6903

kernel: drm/probe-helper: Ensure cmdline mode matches interlace mode
See: raspberrypi/linux#6902

kernel: media: i2c: Tweak default PDAF gain table in imx708 driver
See: raspberrypi/linux#6901

kernel: drivers: media: imx500: Add device id readback control
See: raspberrypi/linux#6897

kernel: overlays: i2c-rtc: Add M41T80 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants