New example for ntp_client with LwIP Socket API #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pico_w/wifi/freertos/ntp_client_socket/picow_freertos_ntp_client_socket.c
Outdated
Show resolved
Hide resolved
|
Looks great - I'll fix the address printing and then maybe just push it to develop. |
peterharperuk
previously approved these changes
Nov 17, 2023
Implemented a new example derived from the existing ntp_client example, but this time using the LwIP Socket API and FreeRTOS NO_SYS=0.
peterharperuk
force-pushed
the
ntp_client_socket
branch
from
ea43f15 to
014ab3a
Compare
peterharperuk
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new example derived from the existing ntp_client example, but this time using the LwIP Socket API and FreeRTOS NO_SYS=0.
This was requested in raspberrypi/pico-sdk#1540.
This depends on raspberrypi/pico-sdk#1530 to match upstream FreeRTOS changes when they merged SMP support.
I tested this locally by manually enabling USB output and disabling UART.
My own primary criticism is that I implemented everything in a single function. It was easier for me to follow, as we no longer need callbacks. I find the code relatively readable, but it may benefit from someone else deciding if it needs more comments.