Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy hello_serial into bootloaders/encrypted #537

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

will-v-pi
Copy link
Contributor

Removes the dependence on a file from a separate folder, which other examples don't have

This would allow the example to be used in the VS Code extension, as that needs examples to be contained in a single directory

Removes the dependence on file from a separate folder, which other examples don't have
@will-v-pi will-v-pi added this to the 2.0.1 milestone Aug 27, 2024
@will-v-pi will-v-pi requested a review from kilograham August 27, 2024 14:52
@lurch
Copy link
Contributor

lurch commented Aug 27, 2024

This would allow the example to be used in the VS Code extension, as that needs examples to be contained in a single directory

Does this also mean that some of the "universal examples" aren't buildable with VS Code? Or is that a non-issue as the VS Code extension doesn't support all the other "infrastructure" needed by those examples anyway?

@will-v-pi
Copy link
Contributor Author

Yeah, those aren't included in the VS Code extension yet, as they need both Arm and Risc-V toolchains. I think it'll be simpler to just add an option to make any binary universal in the extension, rather than including the examples

@kilograham kilograham merged commit 175b382 into raspberrypi:develop Aug 27, 2024
1 check passed
@kilograham
Copy link
Contributor

I don't know that "universal" binary is that common a feature in general.

@will-v-pi will-v-pi deleted the enc-c-file branch October 30, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants