Fix: Local Zephyr snippets not detected without SNIPPET_ROOT#255
Open
MassimilianoPavesio wants to merge 1 commit intoraspberrypi:mainfrom
Open
Fix: Local Zephyr snippets not detected without SNIPPET_ROOT#255MassimilianoPavesio wants to merge 1 commit intoraspberrypi:mainfrom
MassimilianoPavesio wants to merge 1 commit intoraspberrypi:mainfrom
Conversation
Local Zephyr snippets inside <workspace>/snippets were not detected
during build because SNIPPET_ROOT was not explicitly set.
When using:
west build -S usb_serial_port
Zephyr only searched inside the Zephyr repository and failed with:
snippets: error: snippets not found: usb_serial_port
Add:
-DSNIPPET_ROOT=${workspaceFolder}
when enabling the USB console snippet so local snippets are
correctly discovered by the build system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where local Zephyr snippets inside:
<workspace>/snippets/were not detected during build.
When selecting USB console, the extension added:
-S usb_serial_portbut did not set
SNIPPET_ROOT.As a result, Zephyr only searched in the zephyr repository:
Snippet roots for application: <zephyr-main>and failed with:
snippets: error: snippets not found: usb_serial_portFix
Add:
-DSNIPPET_ROOT=${workspaceFolder}when pushing the USB snippet argument:
if (data.console === "USB") { westArgs.push("-S", "usb_serial_port"); westArgs.push("-DSNIPPET_ROOT=${workspaceFolder}"); }This ensures local snippets are correctly discovered.
Tested On
Build succeeds after fix.