showcase: add rustnet - #1118
Conversation
|
Take a bit of a deeper read on #1104 for what we're thinking here. Some subjective UI observations:
Really cool app, not quite at showcase level though yet. I think it could be though. Aim for adding a high level of visual polish to get it there.
|
|
Hi @joshka, Thanks for your comment. I've tried to address most of them and since your review I shipped two UI changes on main:
In addition I also rerecorded the demo at 1200x720 with VHS (domcyrus/rustnet#247). Everything is on main but not released yet. I plan to cut v1.3.0 with this shortly. Happy to wait if you'd like to take another look first, otherwise I'll ping again once v1.3.0 lands. |
|
Hi @joshka, just a quick ping as I mentioned: rustnet v1.3.0 is out since a while (https://github.com/domcyrus/rustnet/releases/tag/v1.3.0) and bundles the TUI refresh from your review. The demo GIF in the PR description points at |
|
Hi @joshka, is there anything concrete you would like me to change? I did address most of your points and shipped v1.3.0 early in May. If RustNet isn't the right fit for the curated set, then no problem closing this PR. Thanks! |
|
My subjective answer is that this is still not quite there yet.
Treat this is still just my subjective feedback. It's not that this is bad generally, it's just not 100% polished yet. It's better than some of the items on the showcase for sure (there's a bunch we should remove though ;)) Even with this sort of tweaks, it might be too close to too many other apps that are already on the showcase. I'd say the best looking one here is https://ratatui.rs/showcase/apps/#openapi-tui. https://ratatui.rs/showcase/apps/#yozefu is a good example of where it's still bordered boxes layout, but it doesn't feel stale for some reason. Trippy and bandwich (arguably probably a bit worse for UI) both cover some of the similar conceptual area you're targeting (network connections) |
|
@joshka Thanks a lot for the very good and detailed review. I will use a lot of this feedback to change the UI look of RustNet, even if I don't always share the same opinion for example regarding emojis in TUIs. I'll credit you in the next changelog. One thought on the overlap concern: I think the three tools do cover different things and aren't just "network apps". Trippy is an active prober, which is the opposite of RustNet's entirely passive Anyway, curation is your call and I get that the showcase isn't a directory, so I'm closing this PR. |
|
Thanks for the understanding on this - I think it's reasonable that this could get to the point where it's the best of the tooling that is in the similar space - there's a bunch of things I'd do to get there, but they're all frontend style tweaks and usability things. A good example of one that's much closer is patent over in #1147 - the one problem with that is that it's possibly on the too simple side in terms of functionality, but it looks good. |
Summary
Adds rustnet to the app showcase, slotted alphabetically between
rucolaandscope-tui.I've reviewed the showcase criteria in #986. If the existing demo doesn't yet meet the visual bar (font size, palette, length), happy to re-record with vhs and resubmit, or close this if awesome-ratatui is the better fit (rustnet is already listed there).