docs: Update log-with-tracing.md with trace_dbg! example - #529
Open
kdheepak wants to merge 1 commit into
Open
Conversation
Deploying ratatui with
|
| Latest commit: |
c82448f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30dd7905.ratatui.pages.dev |
| Branch Preview URL: | https://kd-trace-dbg.ratatui.pages.dev |
joshka
approved these changes
Apr 1, 2024
joshka
left a comment
joshka
left a comment
Member
There was a problem hiding this comment.
I'd prefer to be consistent with the tracing-macros crate where this is found and use dbg! instead of trace_dbg!
Minimal preference for consistency. If you disagree based on trace_dbg being a generally better name, I'm happy to accept this as is.
orhun
approved these changes
Apr 1, 2024
Member
|
I asked about the tracing_macros crate in the tokio discord: https://discord.com/channels/500028886025895936/974721015999516672/1224430040423334049 |
Member
Author
|
Happy to rename it! I didn’t realize that I swapped the names. Perhaps because I use |
Member
Ha, I assumed you'd done so with intention :D |
Member
Author
|
If I did intend to do it I promptly forgot about it too :) |
Closed
joshka
added a commit
that referenced
this pull request
Jun 4, 2024
Adds a new `Block::border_set` method that allows the user to specify the symbols used for the border. Added two new border types: `BorderType::QuadrantOutside` and `BorderType::QuadrantInside`. These are used to draw borders using the unicode quadrant characters (which look like half block "pixels"). QuadrantOutside: ``` ▛▀▀▜ ▌ ▐ ▙▄▄▟ ``` QuadrantInside: ``` ▗▄▄▖ ▐ ▌ ▝▀▀▘ ``` Fixes: ratatui/ratatui#528 BREAKING CHANGES: - BorderType::to_line_set is renamed to to_border_set - BorderType::line_symbols is renamed to border_symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.