Having a look at integrating rowan/logos/lalrpop #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the unicode ↔ ascii formatter to work it needs a form of concrete syntax tree,
rowan seems like the thing to use, and seems fairly straightforward to integrate with logos...
It's solidly ugly to pattern match in lalrpop but it does seems to work...
Bottom-up
The current
GreenNodeBuilder
seems primarily geared towards top-down parsers,the path of least resistence in lalrpop is bottom-up.
Lifetimes:
Returning from the parser, via e.g.
GreenNodeBuilder::finish
currently doesn't work,It seems something like the
NodeCache
(which I think is private), might be a usable API for bottom-up construction, and fix this too, essentially building iterators from the bottom up, I imagine for this would have to return[Leaf;1]
, at the bottom...