Skip to content

Commit bd5d8c4

Browse files
committed
RDBC-927 Refactor server version checks in tests: replace is70Server with isRavenDbServerVersion for improved flexibility; update test descriptions accordingly.
1 parent a920823 commit bd5d8c4

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

test/Documents/Queries/VectorSearchTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {disposeTestDocumentStore, RavenTestContext, testContext} from "../../Uti
1010
import {assertThat} from "../../Utils/AssertExtensions.js";
1111

1212

13-
(RavenTestContext.is70Server ? describe : describe.skip)("RDBC-899", function () {
13+
(RavenTestContext.isRavenDbServerVersion("7.0") ? describe : describe.skip)("RDBC-899", function () {
1414
let store: IDocumentStore;
1515

1616
beforeEach(async function () {

test/Ported/Documents/Operations/AiAgentTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import {
44
PutConnectionStringOperation,
55
RavenConnectionString
66
} from "../../../../src/index.js";
7-
import {disposeTestDocumentStore, testContext} from "../../../Utils/TestUtil.js";
7+
import {disposeTestDocumentStore, RavenTestContext, testContext} from "../../../Utils/TestUtil.js";
88
import {assertThat, assertThrows} from "../../../Utils/AssertExtensions.js";
99
import {AiAgentConfiguration} from "../../../../src/Documents/Operations/AI/Agents/config/AiAgentConfiguration.js";
1010

11-
describe("AiAgentTest", function () {
11+
(RavenTestContext.isRavenDbServerVersion("7.1") ? describe : describe.skip)("AiAgentTest", function () {
1212

1313
let store: IDocumentStore;
1414

test/Ported/Documents/Operations/AiConversationTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { IDocumentStore } from "../../../../src/index.js";
2-
import { disposeTestDocumentStore, testContext } from "../../../Utils/TestUtil.js";
2+
import {disposeTestDocumentStore, RavenTestContext, testContext} from "../../../Utils/TestUtil.js";
33
import { assertThat, assertThrows } from "../../../Utils/AssertExtensions.js";
44

55
import { AiHandleErrorStrategy } from "../../../../src/Documents/Operations/AI/AiConversation.js";
66

7-
describe("AiConversationTest", function () {
7+
(RavenTestContext.isRavenDbServerVersion("7.1") ? describe : describe.skip)("AiConversationTest", function () {
88
let store: IDocumentStore;
99

1010
beforeEach(async function () {

test/Utils/TestUtil.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,9 @@ class TestSecuredServiceLocator extends RavenServerLocator {
135135

136136
export class RavenTestContext extends RavenTestDriver implements IDisposable {
137137

138-
public static is70Server = process.env["RAVENDB_SERVER_VERSION"] >= "7.0";
138+
public static isRavenDbServerVersion(version: string): boolean {
139+
return process.env["RAVENDB_SERVER_VERSION"] >= version;
140+
}
139141

140142
public static isPullRequest = !process.env["RAVEN_License"];
141143

0 commit comments

Comments
 (0)