RDBC-935 Add Connection String Operations #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poissoncorp
reviewed
Sep 5, 2025
...s/jvm_migrated_tests/client_tests/documents_tests/operations_tests/test_connection_string.py
Outdated
Show resolved
Hide resolved
poissoncorp
reviewed
Sep 8, 2025
| return { | ||
| "RavenConnectionStrings": self._raven_connection_strings, | ||
| "SqlConnectionStrings": self._sql_connection_strings, | ||
| "OlapConnectionStrings": self._olap_connection_strings, |
There was a problem hiding this comment.
last thing - shouldn't you call to_json on each connection string object from this collection? like this
Suggested change
| "OlapConnectionStrings": self._olap_connection_strings, | |
| "OlapConnectionStrings": [olap_cs.to_json() for olap_cs in self._olap_connection_strings], |
also in from_json - you need to call from_json on each dict in json_dict["RavenConnectionString"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.hibernatingrhinos.com/issue/RDBC-935/Add-Connection-String-Operations