Fix to https://issues.openmrs.org/browse/ERR-652#2
Open
cereblanco wants to merge 1 commit intoravipatipushkar:masterfrom
Open
Fix to https://issues.openmrs.org/browse/ERR-652#2cereblanco wants to merge 1 commit intoravipatipushkar:masterfrom
cereblanco wants to merge 1 commit intoravipatipushkar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ravipatipushkar,
This is a fix to https://issues.openmrs.org/browse/ERR-652.
Basically, what this updated code does is, it saves the uploaded image
in "drawingObs[timestamp].png" instead of just "drawingObs.png".
This is because, in OpenMRS, if you upload a file
and the file has a similar filename in the server already,
the file will be stored in "drawingObs_[counter].png".
However, [counter] loops up to 100 only
(See getOutputFileToWrite method in Abstracthandler Class).
So if the counter is 100 already, any uploaded drawing image
will just overwrite the drawingObs_100.png.
I hope you consider this revision and merge it with the next release of drawing module.
Thanks!
Cereblanco@gmail.com