[POC] RayJob YuniKorn Integration #3379
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Chiu <[email protected]>
troychiu
changed the title
| @@ -77,14 +79,140 @@ func (y *YuniKornScheduler) AddMetadataToPod(ctx context.Context, app *rayv1.Ray | |||
| } | |||
| } | |||
|
|
|||
| func (y *YuniKornScheduler) isGangSchedulingEnabled(app *rayv1.RayCluster) bool { | |||
| _, exist := app.Labels[utils.RayClusterGangSchedulingEnabled] | |||
| func collectLabelsFromObject(obj client.Object, labels map[string]string, sourceKey string, targetKey string) { | |||
There was a problem hiding this comment.
Maybe need to rename this func?
I think the name does not reflect what it does.
| } | ||
|
|
||
| func (y *YuniKornScheduler) isGangSchedulingEnabled(obj client.Object) bool { | ||
| _, exist := obj.GetLabels()[utils.RayClusterGangSchedulingEnabled] | ||
| return exist | ||
| } | ||
|
|
||
| func (y *YuniKornScheduler) populateTaskGroupsAnnotationToPod(ctx context.Context, app *rayv1.RayCluster, pod *corev1.Pod) { |
There was a problem hiding this comment.
I always feel its inconsistent that some where it is named app while some where it's named cluster maybe we should make it more consistent?
| func (v *VolcanoBatchScheduler) PropagateMetadata(_ context.Context, parent client.Object, groupName string, child client.Object) { | ||
| // Only support parent is RayCluster and child is Pod | ||
| pod, ok := child.(*corev1.Pod) | ||
| if !ok { |
There was a problem hiding this comment.
We might need to add some error msg here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage
--set batchScheduler.name=yunikornto enable yunikorn as the scheduler.If everything is setup correctly, you should be able to see
Why are these changes needed?
Related issue number
Checks