Edit RayCluster example config for label selectors #4151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
I think we want leave it as "nightly" because the label selector feature is experimental and there may be bug fixes. |
Future-Outlier
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
I tested with this doc, LGTM, thank you!
ray-project/ray#58157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR edits the example RayCluster yaml for using top-level Labels and the label selector API for this guide: ray-project/ray#58157. The main change here is to remove
nvidia.com/gpuand use the top-level Resources field, as to showcase the CRD change to users and enable the RayCluster worker to actually schedule in the kind cluster for the example.Related issue number
ray-project/ray#51564
Checks