[core] Place object_manager bazel targets into separate directories #52285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @dentiny |
dentiny
approved these changes
Apr 13, 2025
|
Just FYI, we have flaky test on dashboard these days, so might take longer to pass all CI; ping me when it passes, or you think failed tests irrelevant, thanks! |
|
Hey, @dentiny . The ci is ok :) |
|
I just enabled windows and mac test for you --- we've met some nasty platform specific prod issues these day, better to be more careful. Ping me when green. |
|
@dentiny , Ci is green now :) |
|
Triggered windows test. |
Maybe the target name is too long for Windows? cc @dayshah |
yup @Ziy1-Tan Can you change the name of the test and related source files to |
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Ziy1-Tan
force-pushed
the
subbazel_objm
branch
2 times, most recently
from
6a58c48 to
1020202
Compare
jjyao
reviewed
Apr 22, 2025
.bazelrc
Outdated
Comment on lines
3
to
4
| build --local_ram_resources=HOST_RAM*.7 --local_cpu_resources=4 | ||
| build --disk_cache=~/bazel-cache |
There was a problem hiding this comment.
Oops, I'll remove these. They are only used locally.
Signed-off-by: Ziy1-Tan <[email protected]>
ktyxx
pushed a commit
to ktyxx/ray
that referenced
this pull request
Apr 29, 2025
…ay-project#52285) Signed-off-by: Ziy1-Tan <[email protected]>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
May 5, 2025
…ay-project#52285) Signed-off-by: Ziy1-Tan <[email protected]>
zhaoch23
pushed a commit
to Bye-legumes/ray
that referenced
this pull request
May 14, 2025
…ay-project#52285) Signed-off-by: Ziy1-Tan <[email protected]> Signed-off-by: zhaoch23 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #52268
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.