Add multi-node test for symmetric_run. #56556
Open
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Decal <[email protected]>
crypdick
force-pushed
the
tests/symmetric-run
branch
from
444916e to
fddc1f8
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a multi-node test for symmetric_run.py and improves its module docstring. The changes are a good addition and increase test coverage. I have a couple of suggestions to improve the new test's maintainability and robustness by refactoring duplicated code and making assertions less brittle.
Signed-off-by: Ricardo Decal <[email protected]>
jjyao
reviewed
Sep 15, 2025
|
|
||
| common_args = ["--address", address, "--min-nodes", "3", "--", "echo", "ok"] | ||
|
|
||
| with patch("subprocess.run") as mock_run, patch( |
There was a problem hiding this comment.
Can we not mock subprocess.run but let it actually starts Ray nodes.
ray-gardener
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a multi-node test for symmetric_run.py
Related issue number
#55119
#55111
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.