make protoc plugin compatiable for M1 chip & fix some tc #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Gradle build failures when running on M1 chipset
I added a condition to check for OS type and downloads the jar for osx-x86_64 as that still works for M1. If we don't do this, Gradle tries to download the jar osx-aarch_64 which is not available for distribution.
Ref: grpc/grpc-java#7690
✔️ Checklist
build.gradleforprotocandprotoc-gen-grpc-javacorrect versionssnappy-javasrc/test/java/io/odpf/firehose/serializer/MessageToJsonTest.javathat missed a comma in the assertion while comparing timestamp. (Mar 20, 2017, 10:54:00 AM) Missed a comma after20175000to5050because macOS 13 has port5000used by Control Center (link)