Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allocation mapping in payment, refund, invoice #148

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add allocation mapping in payment, refund, invoice #148

wants to merge 5 commits into from

Conversation

ggmaleva
Copy link

No description provided.

@ggmaleva ggmaleva marked this pull request as ready for review June 30, 2021 11:47
strug
strug reviewed Jun 30, 2021
View reviewed changes
src/main/java/com/rbkmoney/hooker/converter/PaymentConverter.java
@@ -65,7 +67,8 @@ private Object getMetadata(com.rbkmoney.damsel.domain.InvoicePayment source) {

private Long getFee(InvoicePayment sourceWrapper) {
return sourceWrapper.isSetCashFlow()
? CashFlowUtils.getFees(sourceWrapper.getCashFlow()).getOrDefault(FeeType.FEE, 0L) : 0L;
? CashFlowUtils.getFees(sourceWrapper.getDeprecatedCashFlow()).getOrDefault(FeeType.FEE, 0L) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот это видимо воротится в итоге в связи с
https://github.com/rbkmoney/damsel/pull/684/files

src/main/java/com/rbkmoney/hooker/converter/PaymentConverter.java Outdated Show resolved Hide resolved
src/main/java/com/rbkmoney/hooker/converter/PaymentConverter.java Outdated Show resolved Hide resolved
src/main/java/com/rbkmoney/hooker/converter/PaymentConverter.java Outdated Show resolved Hide resolved
src/main/java/com/rbkmoney/hooker/converter/PaymentConverter.java Outdated Show resolved Hide resolved
inallyoung
inallyoung suggested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@inallyoung inallyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а как же invoice и refund, в них же тоже может быть allocation?

@ggmaleva
Copy link
Author

а как же invoice и refund, в них же тоже может быть allocation?

не в бровь, а в глаз. буду доделывать

@ggmaleva ggmaleva changed the title add allocation mapping in payment add allocation mapping in payment, refund, invoice Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strug strug strug left review comments

@inallyoung inallyoung inallyoung approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggmaleva @strug @inallyoung