gnome-shell typing oversight #661
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to fix the applet. I see that #636 fixed it (thank you!) and my patch was pretty close to the fix there. However there's this one little nit that I noticed left; there's a small chance this.add_actor could be undefined while this._box.add_actor is.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to fix the applet. I see that #636 fixed it (thank you!) and my final patch ended up pretty close to the fix there.
However there's this one little nit that I noticed left; there's a small chance
this.add_actorcould be undefined whilethis._box.add_actoris. It should follow the rhythm set by the other lines and check precisely what it uses.