change regex for elixir#exunit to enable multi-line do / feature blocks #112
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still doesn't catch these tests either, and I'm not sure how to fix that yet. Is there a better approach to the regex match? |
This will find all of the valid constructions.
```
test "some test" do
test "another test",
%{foo: foo, bar: bar} do
test "a third test", %{baz: baz} do
test "last one", %{
bop: bop,
bap: bap} do
```
are all valid as per the mix formatter and this finds all of those. is this regex strict enough to not provide false positives?
|
Thanks for the PR! Since we're trying to cover a few cases here could you a small test file to here https://github.com/rcarriga/vim-ultest/tree/master/tests/mocks/test_outputs and a corresponding test in https://github.com/rcarriga/vim-ultest/blob/master/tests/unit/handler/parsers/test_file.py. Large regexes are pretty tough to maintain so would be great to be able to make sure it doesn't break 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My regex skills aren't the greatest, but I believe this will work to fix #111