Skip to content

Conversation

@F1NaL
Copy link

@F1NaL F1NaL commented Oct 3, 2016

Related to #280

@barryvdh
Copy link
Collaborator

barryvdh commented Oct 3, 2016

But this probably needs a bump for laravel version?

@F1NaL
Copy link
Author

F1NaL commented Oct 3, 2016

i tested it with 5.2.45

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 24.113% when pulling ad49dda on F1NaL:master into eb65adc on rcrowe:master.

@andmetoo
Copy link

andmetoo commented Oct 3, 2016

Work with latest public version 5.3.15

@barryvdh
Copy link
Collaborator

barryvdh commented Oct 3, 2016

Yes but we're currently supporting 5.0 and up. Which we can bump to 5.1, because that is LTS. So should work on both 5.1 and 5.3

@mbardelmeijer
Copy link
Contributor

Possibly related: twigphp/Twig#2160

@mbardelmeijer
Copy link
Contributor

Is fixed in twig v1.26.1 which just has been released. See twigphp/Twig#2160 & twigphp/Twig#2161

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 25.224% when pulling aa2a364 on F1NaL:master into eb65adc on rcrowe:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants