Core 2442 #9
Open
Core 2442 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanBurton
suggested changes
Oct 26, 2022
Contributor
DanBurton
left a comment
DanBurton
left a comment
There was a problem hiding this comment.
filter/sort stuff lgtm but the detail page got messed up.
src/Gallery/Details.js
Outdated
| <Rarity>{nft ? nft.rarity : ''}</Rarity> | ||
| </Badge> | ||
| <Image src={data.url} /> | ||
| <Image src={nft ? nft.rarity : ''} /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Image src={nft ? nft.rarity : ''} /> | |
| <Image src={nft ? nft.url : ''} /> |
Contributor
There was a problem hiding this comment.
This is one thing wrong with the details page but I think there might be more changes needed to fix it.
Contributor
|
Can you also rebase your branch on latest |
Contributor
|
@phoniks I see that you force pushed, which I presume was an attempt at rebasing on latest master, but it's still showing a bunch of merge conflicts. Can you sort out the merge conflicts and get this PR is in a mergeable state? |
…t-for-sale NFTs from rarity sorting
…ucture of NFTs from Dan
DanBurton
suggested changes
Nov 14, 2022
Contributor
DanBurton
left a comment
DanBurton
left a comment
There was a problem hiding this comment.
When running it locally I'm observing that the filters don't work as intended.
- Only the for sale ones seem to show up regardless of whether I've selected the "for sale" tab or not on top.
- No matter which face filter I select, it only shows me the ones corresponding to
nft.attributes.face == 0 - Similarly, no matter which glasses filter I select, it only shows me the ones corresponding to
nft.attributers.glasses == 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.