DEVX-291c #1425
DEVX-291c #1425
Conversation
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
9694bb9 to
36c6137
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
bd20f16 to
b233a94
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
b233a94 to
b78cccd
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
b78cccd to
7f87ef6
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
3120f9d to
33c9efa
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
33c9efa to
578a07c
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
c901418 to
2fc2307
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
d28329e to
53e5f79
Compare
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
ca2d928 to
f1bdb78
Compare
chrisnevers
left a comment
chrisnevers
left a comment
There was a problem hiding this comment.
Besides these comments, it looks good to me
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
f1bdb78 to
2b2f0d6
Compare
chrisnevers
left a comment
chrisnevers
left a comment
There was a problem hiding this comment.
LGTM after these comments
|
I think gen.log should be gitignored |
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
2954e42 to
d0ddfa3
Compare
chrisnevers
left a comment
chrisnevers
left a comment
There was a problem hiding this comment.
LGTM, I think Jay needs to sign off though
TheChronicMonster
force-pushed
the
DEVX-291c
branch
from
d0ddfa3 to
08ad81e
Compare
| f: null, // freeze address | ||
| defaultFrozen: false, | ||
| reserve: null, | ||
| note: Uint8Array[1], |
There was a problem hiding this comment.
I think this is just undefined and I'm surprised it is not an error
| const transferNFT = async (minter, receiver, nftId, supply) => { | ||
| const preAmtNFT = await logBalance(minter, nftId); | ||
|
|
||
| if (stdlib.connector == 'ALGO') { |
There was a problem hiding this comment.
I think you should always do it and note that it does nothing on ETH
| const getBal = async (who, tok) => tok ? (await stdlib.balanceOf(who, tok)) : fmt(await stdlib.balanceOf(who)); | ||
|
|
||
| const logBalance = async (acc, tok) => { |
There was a problem hiding this comment.
In these two functions, you have an "acceptable" path on tok being undefined. I think it is kinder to use (who, tok = false), to better communicate to the reader that often you expect it to not be provided
| f: null, // freeze address | ||
| defaultFrozen: false, | ||
| reserve: null, | ||
| note: Uint8Array[1], |
There was a problem hiding this comment.
I think that you should use the ARC spec and have the note actually contain what it is supposed to
|
|
||
| const opts = { | ||
| supply: 1, | ||
| url: "ipfs://bafybeigdyrzt5...", //asset url |
There was a problem hiding this comment.
I think it is more compelling if you demonstrate actually creating it too. The same information that you're going to put in the Note field, you want to upload to IPFS.
This page has a little tutorial:
under "Adding data to IPFS"
If you are nervous about including it in the code always or having our CI do it, etc, then at least make a little program on the side (or a way to run this program) and comment on it in your guide
No description provided.