This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Conversation
taion
commented
Jun 10, 2017
Member
Author
taion
left a comment
taion
left a comment
There was a problem hiding this comment.
i meant to switch out react-prop-types for prop-types-extra but got carried away
| } | ||
|
|
||
| getStatus = () => { | ||
| // FIXME: This test breaks when using a functional ref. |
| }, | ||
| const docsConfig = require('./docs.config'); | ||
|
|
||
| module.exports = Object.assign( |
Member
Author
There was a problem hiding this comment.
HMR wasn't properly working on master anyway (it would complain that it'd have to reload the page). Getting rid of that lets me just merge these two configs.
| "build:examples": "npm run clean:examples && webpack --config webpack/docs.config.js", | ||
| "examples": "npm run clean:examples && babel-node examples/server.js", | ||
| "lint": "eslint examples/*.js src test *.js", | ||
| "examples": "webpack-dev-server --config webpack/examples.config.js --hot --port 3000 --progress", |
Member
Author
There was a problem hiding this comment.
bizarrely, doing --hot here is different from doing hot: true in the config. the webpack 1 docs mentioned this (if you did --hot --inline), but the webpack 2 docs AFAICT don't
Member
Author
|
Not sure why we had Coveralls set up... this repo wasn't on Coveralls |
Member
Author
|
The codecov failures are pointless |
jquense
approved these changes
Jun 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.