Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter 'info' field 'index' to tagRender #1108

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 12, 2025

close ant-design/ant-design#31501

Summary by CodeRabbit

  • 依赖更新

    • rc-overflow 依赖版本从 ^1.3.1 更新至 ^1.4.0
  • 新功能

    • 为选择器组件添加了标签索引支持
    • 在标签渲染时可以获取和使用标签的索引信息
  • 测试

    • 新增了针对标签渲染索引的测试用例,确保索引功能正常工作

… in rc-overflow to the tagRender method (#1102)

* feat:从rc-overflow的renderItem中获取info参数,后添加到tagRender中

* 修改不正确的类型定义

---------

Co-authored-by: 刘欢 <[email protected]>
Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 7:28am

Copy link
Contributor

coderabbitai bot commented Jan 12, 2025

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/BaseSelect/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

  • /.eslintrc.js
  • /node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
    at Module._load (node:internal/modules/cjs/loader:1074:27)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)
    at require (node:internal/modules/helpers:135:16)
    at Object. (/.eslintrc.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Module.load (node:internal/modules/cjs/loader:1317:32)

变更概览

演练

此次拉取请求主要修改了 rc-select 包的代码,增加了在标签渲染时传递索引的功能。具体变更包括更新 package.jsonrc-overflow 依赖的版本,并在 CustomTagPropsDisplayValueType 和相关组件中添加了 index 属性,以支持在标签渲染时获取和使用标签的索引信息。

变更

文件 变更摘要
package.json rc-overflow 依赖版本从 ^1.3.1 更新到 ^1.4.0
src/BaseSelect/index.tsx CustomTagProps 类型中添加 index: number 属性
src/Selector/MultipleSelector.tsx 更新 customizeRenderSelectorrenderItem 方法签名,增加 index 参数
src/interface.ts DisplayValueType 接口中新增可选的 index?: number 属性
tests/Tags.test.tsx 新增测试用例,验证 tagRender 函数接收 index 属性

对链接问题的评估

目标 是否已解决 说明
tagRender 回调添加索引 [#31501]

可能相关的 PR

建议的审阅者

  • zombieJ

诗歌

🐰 代码如春风,
索引随风舞,
标签有了灵魂,
每一行都有故事,
编程的魔法闪耀!🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa18f57 and 3a729ce.

📒 Files selected for processing (5)
  • package.json (1 hunks)
  • src/BaseSelect/index.tsx (1 hunks)
  • src/Selector/MultipleSelector.tsx (4 hunks)
  • src/interface.ts (1 hunks)
  • tests/Tags.test.tsx (2 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afc163 afc163 changed the title feat:Give the parameter 'info' field 'index' of the renderItem method… feat: add parameter 'info' field 'index' to tagRender Jan 12, 2025
@afc163 afc163 changed the base branch from master to 14.x January 12, 2025 07:28
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (fd1f076) to head (3a729ce).
Report is 1 commits behind head on 14.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             14.x    #1108      +/-   ##
==========================================
+ Coverage   98.31%   98.46%   +0.15%     
==========================================
  Files          39       39              
  Lines        1487     1633     +146     
  Branches      443      535      +92     
==========================================
+ Hits         1462     1608     +146     
  Misses         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 0200d6d into 14.x Jan 12, 2025
10 of 11 checks passed
@afc163 afc163 deleted the fix/tagRender-index-param branch January 12, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add index to tagRender callback on Select with mode="tags"
2 participants