add prebuild script to collect peerdeps #765
Open
+123
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question of #747 pops to mind here. If the official stance of this library is that there is a hard dependency on standard schemas with the view of eventually making it the only option once ecosystem adoption grows then great, we keep it in. We should probably also add |
aqeelat
reviewed
Jun 16, 2025
| @@ -317,9 +318,91 @@ | |||
| "zod": "^3.24.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "react-hook-form": "^7.55.0" | |||
| "react-hook-form": "^7.55.0", | |||
| "@hookform/resolvers": "^2.0.0", | |||
There was a problem hiding this comment.
why are you depending on the package itself?
aqeelat
reviewed
Jun 16, 2025
Comment on lines
+13
to
+15
| const peerDependencies = Object.fromEntries( | ||
| packageJsons.flatMap((pj) => Object.entries(pj?.peerDependencies ?? {})), | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const peerDependencies = Object.fromEntries( | |
| packageJsons.flatMap((pj) => Object.entries(pj?.peerDependencies ?? {})), | |
| ); | |
| const topLevelPackageJson = JSON.parse(await fs.readFile('package.json')) | |
| const peerDependencies = Object.fromEntries( | |
| packageJsons | |
| .flatMap((pj) => Object.entries(pj?.peerDependencies ?? {})) | |
| .filter(([name]) => name !== topLevelPackageJson.name), | |
| ) |
| ); | ||
|
|
||
| const packageJson = { | ||
| ...JSON.parse(await fs.readFile('package.json')), |
There was a problem hiding this comment.
Suggested change
| ...JSON.parse(await fs.readFile('package.json')), | |
| ...topLevelPackageJson, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple js script that is run before builds and commits that collects all peerDependencies from all subfolders together and inserts them into the root package.json. This closes #762