Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useScrolling): new hook useScrolling #1320

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(useScrolling): new hook useScrolling #1320

wants to merge 8 commits into from

Conversation

Frankcaozas
Copy link

@Frankcaozas Frankcaozas commented Jul 23, 2023 •
edited
Loading

what new hook does

tracks whether HTML element is scrolling

Checklist

  • Have you read the contribution guidelines?
  • If you are porting a hook from react-use, have you checked Port remaining hooks from react-use #33 and the migration guide
    to confirm that the hook has been approved for porting?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have you written tests for the new hook?
  • Have you run the tests locally to confirm they pass?

@Frankcaozas Frankcaozas changed the title feat(useScrolling): new hook useScrolling feat(useScrolling): new hook useScrolling Jul 25, 2023
@Frankcaozas Frankcaozas changed the title feat(useScrolling): new hook useScrolling feat(useScrolling): new hook useScrolling Jul 25, 2023
@Frankcaozas
Copy link
Author

Frankcaozas commented Jul 27, 2023 •
edited
Loading

@xobotyi @JoeDuncko ready to be review

@JoeDuncko JoeDuncko requested a review from xobotyi July 31, 2023 13:15
@Frankcaozas Frankcaozas reopened this Sep 5, 2023
@xobotyi
Copy link
Contributor

xobotyi commented Sep 11, 2023

@Frankcaozas really sorry for delay - im planning to review it in closest two weeks.

@Frankcaozas
Copy link
Author

@xobotyi please review this PR

@xobotyi
Copy link
Contributor

xobotyi commented Oct 15, 2023

Please fix conflicts

@Frankcaozas Frankcaozas reopened this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobotyi xobotyi Awaiting requested review from xobotyi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frankcaozas @xobotyi