[0.80] AsyncStorageModule should not implement ModuleDataCleaner.Cleanable #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable This interface is now `internal` inside React Native (starting from 0.80) and will be removed in a future version of React Native. The methods `clearSensitiveData` was never called altogether so it's safe to remove.
|
|
cc @tido64 upstream change is here: facebook/react-native#51060 |
Can you also add a change file? See #1205 (comment) |
|
@tido64 added |
|
thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This interface is now
internalinside React Native (starting from 0.80) and will be removed in a future version of React Native.The methods
clearSensitiveDatawas never called altogether so it's safe to remove.Test Plan
I guess I will rely on CI being green here