Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate package for PackageManager util #2462

Conversation

arpitBhalla
Copy link

@arpitBhalla arpitBhalla commented Jul 22, 2024

Summary:

  • Separated PackageManager into another package

Related rise-tools/rise-tools#161

Test Plan:

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

^ @grabbou

@github-actions github-actions bot added docs Documentation change feature labels Jul 22, 2024
@arpitBhalla arpitBhalla reopened this Jul 23, 2024
Copy link
Collaborator

@TMisiukiewicz TMisiukiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! In my opinion, in this PR we should focus only on extracting currently existing logic into separate package. IIRC pnpm still requires some tweaks to make it work with CLI, (check here) so to not block things, I'd remove pnpm part from this PR

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left few nits comments

@szymonrybczak
Copy link
Collaborator

@arpitBhalla can you take a look at failing tests? 🙏

Copy link

github-actions bot commented Feb 4, 2025

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Feb 4, 2025
@github-actions github-actions bot closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants