Skip to content

Conversation

@jquense
Copy link
Member

@jquense jquense commented Jul 28, 2025

does what it says!

@jquense jquense requested a review from kyletsang July 28, 2025 20:35
@kyletsang
Copy link
Collaborator

kyletsang commented Jul 29, 2025

Some observations:

  • Minor alignment issue for the home icon on the new breadcrumbs on each page
  • Vanilla button styling isn't working on the first couple examples on the button page. Looks like the className prop is no longer propagating from mdx to live code block
  • In the modal stacking example (http://localhost:3000/ui/Modal#modal-stacking), there's an error from emotion TypeError: Failed to resolve module specifier '@emotion/styled'
  • In the overlay animation example (http://localhost:3000/ui/Overlay#animations), there's an error TypeError: Failed to resolve module specifier 'react-transition-group/Transition'
  • The portal example doesn't render. Looks like this needs to be embedded into a function now
  • Error in the waypoint hook example (http://localhost:3000/ui/Waypoint#usewaypoint): TypeError: Failed to resolve module specifier '@restart/ui/useWaypoint'
  • Error in the useRootClose hook docs (http://localhost:3000/ui/useRootClose). Same as portal, needs to be rendered in a function now
  • Error here: http://localhost:3000/ui/transitions#transition-component
  • Imperative custom transitions animation is kinda janky on dismiss. Not sure if it was like this before. Also needs some padding

Random note not related to this PR, but I noticed the docs mention the transition prop accepts a RTG v2-compatible component. Should probably bump to v4-compatible.

@jquense jquense merged commit c08dfa5 into main Aug 1, 2025
4 of 7 checks passed
@jquense jquense deleted the jq/docs-update branch August 1, 2025 17:27
@jquense
Copy link
Member Author

jquense commented Aug 1, 2025

I think i fixed most/all things, can follow up as needed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants