Skip to content

More intuitive channel layer hook #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 14, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Mar 13, 2025

Description

This PR is mainly to sync some changes that have been sitting in my local branch for a while.

  • Updated the interface for reactpy.hooks.use_channel_layer to be more intuitive.
    • Arguments now must be provided as keyworded arguments.
    • The name argument has been renamed to channel.
    • The group_name argument has been renamed to group.
    • The group_add and group_discard arguments have been removed for simplicity.
  • Preemptively do some changes related to reactpy v2
    • Migrate del_html_head_body_transform from reactpy to django-reactpy
  • Add logging when RESOLVED_WEB_MODULES_PATH fails to fetch

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger requested a review from a team as a code owner March 13, 2025 05:53
@Archmonger Archmonger force-pushed the use-channel-layer-rework branch from 8d30fcd to 78d51a3 Compare March 13, 2025 20:34
@Archmonger Archmonger merged commit c8ec533 into reactive-python:main Mar 14, 2025
45 checks passed
@Archmonger Archmonger deleted the use-channel-layer-rework branch March 14, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant