Skip to content

Run test webserver within main async loop #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Archmonger
Copy link
Contributor

Description

The test webserver struggles to startup/shutdown on GitHub Actions, seemingly due to weirdness with Python threads.

Unfortunately, subprocesses won't work due to pickling issues. As a result, the only obvious alternative is running the webserver directly within the main thread's asyncio loop.

This seems to work for the purpose of running tests.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger changed the base branch from main to develop February 3, 2025 00:42
@Archmonger Archmonger marked this pull request as ready for review February 3, 2025 01:20
@Archmonger Archmonger merged commit 1069928 into reactive-python:develop Feb 3, 2025
17 checks passed
@Archmonger Archmonger deleted the v2-more-stable-test-webserver branch February 3, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant