fixes #4

read2me-online · May 4, 2018 · 649d4fb · 649d4fb
1 parent f08adf9
commit 649d4fb
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 3 deletions.
diff --git a/src/Item.php b/src/Item.php
@@ -47,13 +47,17 @@ class Item implements ItemInterface
      * @var null|string
      */
     private $guid;
+    /**
+     * @var bool|string
+     */
+    private $link;
 
     private static $template;
 
     public function __construct(
         string $title, string $fileUrl, string $duration,
         string $description, int $publishDate, int $fileSizeBytes,
-        string $mime, ?string $guid = null
+        string $mime, ?string $guid = null, ?string $link = null
     ) {
         $this->title = $this->escape($title);
         $this->fileUrl = $fileUrl;
@@ -63,6 +67,7 @@ public function __construct(
         $this->fileSizeBytes = $fileSizeBytes;
         $this->mime = $mime;
         $this->guid = $guid ?: $this->fileUrl;
+        $this->link = $link ?: $this->fileUrl;
 
         if (empty(self::$template)) // avoid disk IO for every item instance
             self::$template = file_get_contents(__DIR__ . '/templates/item.xml');

diff --git a/src/templates/item.xml b/src/templates/item.xml
@@ -10,4 +10,5 @@
 
     <enclosure url="{{fileUrl}}" length="{{fileSizeBytes}}" type="{{mime}}" />
     <guid>{{guid}}</guid>
+    <link>{{link}}</link>
 </item>
diff --git a/tests/ItemTest.php b/tests/ItemTest.php
@@ -21,11 +21,11 @@ class ItemTest extends TestCase
     private const Filesize = 828387;
     private const Mime = 'audio/mpeg';
 
-    public static function getItem(?string $guid = null): Item {
+    public static function getItem(?string $guid = null, ?string $link = null): Item {
         return new Item(
             self::Title, self::File_Url, self::Duration,
             self::Description, self::Date, self::Filesize,
-            self::Mime, $guid
+            self::Mime, $guid, $link
         );
     }
 
@@ -44,4 +44,12 @@ public function testCustomGuid(): void {
 
         $this->assertEquals($expected, $actual);
     }
+
+    public function testCustomLink(): void {
+        $item = static::getItem(null, 'https://mysite.com/podcast/episodes/123');
+        $expected = file_get_contents(__DIR__ . '/fixtures/item-custom-link.xml');
+        $actual = $item->getXml();
+
+        $this->assertEquals($expected, $actual);
+    }
 }
diff --git a/tests/fixtures/feed.xml b/tests/fixtures/feed.xml
@@ -36,6 +36,7 @@
 
     <enclosure url="https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3" length="828387" type="audio/mpeg" />
     <guid>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</guid>
+    <link>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</link>
 </item>
 <item>
     <title>Trump Says Disclosure of Mueller Questions in Russia Probe Is ‘Disgraceful’</title>
@@ -49,6 +50,7 @@
 
     <enclosure url="https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3" length="828387" type="audio/mpeg" />
     <guid>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</guid>
+    <link>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</link>
 </item>
 
     </channel>

diff --git a/tests/fixtures/item-custom-guid.xml b/tests/fixtures/item-custom-guid.xml
@@ -10,4 +10,5 @@
 
     <enclosure url="https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3" length="828387" type="audio/mpeg" />
     <guid>foobar</guid>
+    <link>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</link>
 </item>
diff --git a/tests/fixtures/item-custom-link.xml b/tests/fixtures/item-custom-link.xml
@@ -0,0 +1,14 @@
+<item>
+    <title>Trump Says Disclosure of Mueller Questions in Russia Probe Is ‘Disgraceful’</title>
+    <link>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</link>
+
+    <duration>2:18</duration>
+    <itunes:duration>2:18</itunes:duration>
+
+    <description>WASHINGTON — President Trump on Tuesday said it was “disgraceful” that questions the special counsel would like to ask him were publicly disclosed, and he incorrectly noted that there were no questions about collusion. The president also said collusion was a “phony” crime.</description>
+    <pubDate>Tue, 01 May 2018 12:30:08 +0000</pubDate>
+
+    <enclosure url="https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3" length="828387" type="audio/mpeg" />
+    <guid>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</guid>
+    <link>https://mysite.com/podcast/episodes/123</link>
+</item>
diff --git a/tests/fixtures/item.xml b/tests/fixtures/item.xml
@@ -10,4 +10,5 @@
 
     <enclosure url="https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3" length="828387" type="audio/mpeg" />
     <guid>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</guid>
+    <link>https://s3.read2me.online/audio/www-nytimes-com-2018-05-01-us-politics-trump-mueller-russia-questions-html-7e9601.mp3</link>
 </item>