Skip to content

Speed up initialization of ExoPlayerEngine #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

mickael-menu
Copy link
Member

We are currently waiting for the first audio resource to buffer before considering the ExoPlayerEngine initialized. This can significantly slow down the opening of the audio navigator in case of network latency.

This change will return the audio navigator as soon as we enter the ExoPlayer buffering state. Integrators can then display a spinner to indicate that the audiobook is not yet ready or delay opening the reader to maintain the current behavior.

@mickael-menu mickael-menu requested a review from qnga February 24, 2025 09:51
Copy link
Member

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mickael-menu mickael-menu merged commit ef0a4f5 into develop Feb 24, 2025
4 checks passed
@mickael-menu mickael-menu deleted the optim-audio-navigator branch February 24, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants