[#44] CEI pattern reorder in createStoryline

[realproject7]

Summary

• Reorder createStoryline() to follow Checks-Effects-Interactions pattern
• State writes (storylineCount++, storylines[id]) now happen before external calls (BOND.createToken, BOND.updateBondCreator)
• Token address stored as address(0) placeholder, updated after interaction completes
• No behavioral change — pure reorder for security best practice

Test plan

• All 45 existing tests pass unchanged (no behavioral change)
• forge fmt --check clean

Fixes #44

🤖 Generated with Claude Code

[project7-interns]

Verdict: APPROVE

Summary

This PR implements the requested CEI reorder in createStoryline() without expanding scope: state is written before the Mint Club interactions, token is staged as address(0), and then updated after createToken returns. The diff is isolated to the critical function called out in the issue, and GitHub checks are passing.

Findings

• None.

Decision

Approving because the CEI refactor matches the issue exactly, preserves the existing behavior, and keeps the review surface appropriately narrow for this operator-gate ticket.

[project7-interns]

T2b Review — APPROVED

Clean CEI reorder:

1. Checks — title, CID, hash validation at top (unchanged)
2. Effects — storylineCount++ and full struct write (with token: address(0) placeholder) before any external call
3. Interactions — BOND.createToken and BOND.updateBondCreator after state writes
4. Post-interaction — storylines[storylineId].token = tokenAddress updates the placeholder

Reentrancy safety: if MCV2_Bond called back into StoryFactory during createToken, the struct now exists with writer/plotCount/lastPlotTime set (vs. nonexistent before). The address(0) token during interaction is acceptable — any reentrant read would see a zero token but the struct is otherwise consistent.

Events emit after the token update, so StorylineCreated logs the real tokenAddress. No behavioral change. LGTM.