Skip to content

[#45] Update E2E scripts for post-#38 contract changes #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 3 commits into from
Mar 20, 2026
Merged

[#45] Update E2E scripts for post-#38 contract changes #50

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e32742
[#45] Update E2E scripts for post-#38 contract changes
realproject7 Mar 20, 2026
cacb6ef
[#45] Add missing E2E scenarios: updateCurve, hasSunset expired, cons…
realproject7 Mar 20, 2026
e56348f
[#45] Fix review: hasSunset expired uses A1, updateCurve proves new c…
realproject7 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/E2ETest.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract E2ETest is Script {
// -----------------------------------------------------------------------
// Base mainnet addresses
// -----------------------------------------------------------------------
StoryFactory constant FACTORY = StoryFactory(0xc278F4099298118efA8dF30DF0F4876632571948);
StoryFactory constant FACTORY = StoryFactory(0x27B4FCf333f29a3865b3B76ea00C955D7b64BD0F);
IERC20 constant PL_TEST = IERC20(0xF8A2C39111FCEB9C950aAf28A9E34EBaD99b85C1);
IMCV2_Bond constant BOND = IMCV2_Bond(0xc5a076cad94176c2996B32d8466Be1cE757FAa27);

Expand Down
50 changes: 49 additions & 1 deletion script/E2ETestReverts.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {IERC20} from "../src/interfaces/IERC20.sol";
/// under --broadcast. Run with `forge script` (no --broadcast flag).
/// Requires the main E2ETest to have run first (needs existing storylines).
contract E2ETestReverts is Script {
StoryFactory constant FACTORY = StoryFactory(0xc278F4099298118efA8dF30DF0F4876632571948);
StoryFactory constant FACTORY = StoryFactory(0x27B4FCf333f29a3865b3B76ea00C955D7b64BD0F);
IERC20 constant PL_TEST = IERC20(0xF8A2C39111FCEB9C950aAf28A9E34EBaD99b85C1);
IMCV2_Bond constant BOND = IMCV2_Bond(0xc5a076cad94176c2996B32d8466Be1cE757FAa27);

Expand Down Expand Up @@ -145,6 +145,44 @@ contract E2ETestReverts is Script {
scenariosPassed++;
}

// E10: chainPlot with empty title (new validation from #42)
vm.prank(deployer);
try FACTORY.chainPlot(idA1, "", CID_46, HASH_A) {
revert("E10: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Empty title"), "E10: wrong revert reason");
console.log('[E10] Empty title in chainPlot reverts PASS "Empty title"');
scenariosPassed++;
}

// E11: createStoryline with zero hash
try FACTORY.createStoryline("Test", CID_46, bytes32(0), false) {
revert("E11: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Empty hash"), "E11: wrong revert reason");
console.log('[E11] Zero hash in create reverts PASS "Empty hash"');
scenariosPassed++;
}

// E12: chainPlot with zero hash
vm.prank(deployer);
try FACTORY.chainPlot(idA1, "Test", CID_46, bytes32(0)) {
revert("E12: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Empty hash"), "E12: wrong revert reason");
console.log('[E12] Zero hash in chainPlot reverts PASS "Empty hash"');
scenariosPassed++;
}

// E13: updateCurve by non-owner
try FACTORY.updateCurve(new uint128[](1), new uint128[](1)) {
revert("E13: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Not owner"), "E13: wrong revert reason");
console.log('[E13] Non-owner updateCurve reverts PASS "Not owner"');
scenariosPassed++;
}

// ===== F3: Zero creation fee =====
console.log("");
console.log("--- Group F: Edge Cases (reverts) ---");
Expand All @@ -156,6 +194,16 @@ contract E2ETestReverts is Script {
scenariosPassed++;
}

// ===== Group G: hasSunset view =====
console.log("");
console.log("--- Group G: hasSunset ---");

// G1: hasSunset on active storyline (no deadline) — should be false
bool sunset1 = FACTORY.hasSunset(idA1);
require(!sunset1, "G1: hasSunset should be false for no-deadline storyline");
console.log("[G1] hasSunset (no deadline) = false PASS");
scenariosPassed++;

console.log("");
console.log("=== ALL REVERT TESTS PASSED ===");
console.log("Scenarios passed:", scenariosPassed);
Expand Down