[#52] Update factory address after v3 redeploy#54
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
New StoryFactory at 0x337c5b96f03fB335b433291695A4171fd5dED8B0 (initialStorylineCount=8). Updated E2E scripts and broadcast artifacts. Contract E2E: all scenarios PASS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Factory address updated in E2E scripts, deployment artifacts and E2E results committed. CI green. Approved.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR is consistent with the v3 redeploy follow-up for issue #52. It updates both contract E2E scripts to the new factory address and includes the expected deploy/broadcast artifacts for the new Base mainnet deployment.
Findings
- None.
Decision
Approved. The functional changes are limited to swapping the E2E scripts onto the new factory address, and the attached artifacts/results are consistent with the redeploy at 0x337c5b96f03fB335b433291695A4171fd5dED8B0. GitHub checks are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x337c5b96f03fB335b433291695A4171fd5dED8B0(withinitialStorylineCount=8)/api/index/tradeendpoint, localhost app not running)Fixes #52
Test plan
forge build— compilesforge script E2ETest.s.sol --broadcast) — all scenarios PASS🤖 Generated with Claude Code