Skip to content

[#56] Update bonding curve to 500-step exponential#57

Merged
realproject7 merged 2 commits intomainfrom
task/56-update-curve-500step
Mar 20, 2026
Merged

[#56] Update bonding curve to 500-step exponential#57
realproject7 merged 2 commits intomainfrom
task/56-update-curve-500step

Conversation

@realproject7
Copy link
Owner

Summary

  • Created script/UpdateCurve.s.sol with exact 500 hardcoded data points from issue [Mainnet] Update bonding curve to 500-step exponential via updateCurve() #56
  • Ran updateCurve() on v3 factory (0x337c5b96...) from owner wallet — tx succeeded
  • Verified on-chain: step 0 = 0.001, step 1 = 0.0010068, step 499 = 1.8882421
  • Created test storyline PL-16 after update — priceForNextMint = 0.001 (confirms new curve active)

Fixes #56

Test plan

  • forge build — compiles
  • updateCurve() tx succeeded on mainnet
  • On-chain verification: cast call for steps 0, 1, 499 — all match
  • Test storyline PL-16 uses 500-step curve (price = 0.001, not 0.002)

🤖 Generated with Claude Code

Hardcoded exact 500 data points from issue #56 (source of truth).
Ran on mainnet — tx succeeded. Verified on-chain:
  Step 0: 0.001, Step 1: 0.0010068, Step 499: 1.8882421
Test storyline PL-16 created with new curve (priceForNextMint = 0.001).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: CI fails on forge fmt — trailing blank line at end of UpdateCurve.s.sol (line 1077). Run forge fmt and push. Code logic is correct.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The on-chain work may be fine, but the PR is not merge-ready because CI is red on formatting.

Findings

  • [medium] Both required Foundry checks fail at on , so the branch does not currently satisfy the repo's required CI gate.
    • File: script/UpdateCurve.s.sol:1077
    • Suggestion: run on the new script and push the formatted file so CI passes.

Decision

Requesting changes because the PR currently fails both GitHub checks, and I do not approve red CI on a deploy-script PR.

Copy link
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The on-chain work may be fine, but the PR is not merge-ready because CI is red on formatting.

Findings

  • [medium] Both required Foundry checks fail at forge fmt --check on script/UpdateCurve.s.sol, so the branch does not currently satisfy the repo's required CI gate.
    • File: script/UpdateCurve.s.sol:1077
    • Suggestion: run forge fmt on the new script and push the formatted file so CI passes.

Decision

Requesting changes because the PR currently fails both GitHub checks, and I do not approve red CI on a deploy-script PR.

Copy link
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI green after fmt fix. 500-step hardcoded values, updateCurve() script structure is clean. Approved.

Copy link
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The formatting-only CI blocker is fixed. Foundry checks are now green, and the hardcoded verification points I spot-checked still match the source issue values.

Findings

  • None.

Decision

Approved. The PR is now merge-ready with green CI, and the deploy script satisfies the required hardcoded-curve constraints for issue #56.

@realproject7 realproject7 merged commit 5c6b019 into main Mar 20, 2026
2 checks passed
@realproject7 realproject7 deleted the task/56-update-curve-500step branch March 20, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mainnet] Update bonding curve to 500-step exponential via updateCurve()

2 participants