[#56] Update bonding curve to 500-step exponential#57
Conversation
Hardcoded exact 500 data points from issue #56 (source of truth). Ran on mainnet — tx succeeded. Verified on-chain: Step 0: 0.001, Step 1: 0.0010068, Step 499: 1.8882421 Test storyline PL-16 created with new curve (priceForNextMint = 0.001). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Minor: CI fails on forge fmt — trailing blank line at end of UpdateCurve.s.sol (line 1077). Run forge fmt and push. Code logic is correct.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The on-chain work may be fine, but the PR is not merge-ready because CI is red on formatting.
Findings
- [medium] Both required Foundry checks fail at on , so the branch does not currently satisfy the repo's required CI gate.
- File: script/UpdateCurve.s.sol:1077
- Suggestion: run on the new script and push the formatted file so CI passes.
Decision
Requesting changes because the PR currently fails both GitHub checks, and I do not approve red CI on a deploy-script PR.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The on-chain work may be fine, but the PR is not merge-ready because CI is red on formatting.
Findings
- [medium] Both required Foundry checks fail at forge fmt --check on script/UpdateCurve.s.sol, so the branch does not currently satisfy the repo's required CI gate.
- File: script/UpdateCurve.s.sol:1077
- Suggestion: run forge fmt on the new script and push the formatted file so CI passes.
Decision
Requesting changes because the PR currently fails both GitHub checks, and I do not approve red CI on a deploy-script PR.
project7-interns
left a comment
There was a problem hiding this comment.
CI green after fmt fix. 500-step hardcoded values, updateCurve() script structure is clean. Approved.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The formatting-only CI blocker is fixed. Foundry checks are now green, and the hardcoded verification points I spot-checked still match the source issue values.
Findings
- None.
Decision
Approved. The PR is now merge-ready with green CI, and the deploy script satisfies the required hardcoded-curve constraints for issue #56.
Summary
script/UpdateCurve.s.solwith exact 500 hardcoded data points from issue [Mainnet] Update bonding curve to 500-step exponential via updateCurve() #56updateCurve()on v3 factory (0x337c5b96...) from owner wallet — tx succeededpriceForNextMint= 0.001 (confirms new curve active)Fixes #56
Test plan
forge build— compilesupdateCurve()tx succeeded on mainnetcast callfor steps 0, 1, 499 — all match🤖 Generated with Claude Code